Skip to content

Fixes inconsistency and error message for array keys #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes inconsistency and error message for array keys #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ module.exports = class HyperDown extends AbstractLevelDOWN {
// Quick check that will pass for valid keys.
else if (typeof key === 'string') return key
else if (Buffer.isBuffer(key) && EMPTY.equals(key)) throw new Error('key cannot be an empty Buffer')
else if ((key instanceof Array) && key.length === 0) throw new Error('key cannot be an empty string')
else if (Array.isArray(key)) {
if (key.length === 0) throw new Error('key cannot be an empty Array')
key = key.join(',')
}
else if (typeof key === 'number' || typeof key === 'boolean') key = String(key)
else if (Array.isArray(key)) key = key.join(',')
return key
}

Expand Down