Skip to content

fix: Using Uint8Array instead of Buffer to test for empty input #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Using Uint8Array instead of Buffer to test for empty input #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24018d9
fix: Using Uint8Array instead of Buffer to test for empty input
martinheidegger Sep 3, 2020
2c7e887
Merge branch 'master' into fix/uint8array-check
martinheidegger Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ const {
AbstractIterator
} = require('abstract-leveldown')

const EMPTY = Buffer.alloc(0)

module.exports = class HyperDown extends AbstractLevelDOWN {
constructor (tree) {
super()
Expand All @@ -18,7 +16,7 @@ module.exports = class HyperDown extends AbstractLevelDOWN {
else if (key === '') throw new Error('key cannot be an empty string')
// Quick check that will pass for valid keys.
else if (typeof key === 'string') return key
else if (Buffer.isBuffer(key) && EMPTY.equals(key)) throw new Error('key cannot be an empty Buffer')
else if (key instanceof Uint8Array && key.length === 0) throw new Error('key cannot be an empty Uint8Array')
else if ((key instanceof Array) && key.length === 0) throw new Error('key cannot be an empty string')
else if (typeof key === 'number' || typeof key === 'boolean') key = String(key)
else if (Array.isArray(key)) key = key.join(',')
Expand Down