Cw telemetry 2 (excluding 1) #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVM27 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
andrewyuq
force-pushed
the
cw-telemetry-2
branch
from
443ea87 to
2a414b3
Compare
* Track SessionContext instead of InvocationContext 1. Since the shift from displaying one trigger at a time to displaying multiple triggers at a time, use SessionContext as the disposable for the session states. 2. Introduce the concept of "display session" which can show multiple triggers at a time and sessionContext is to hold states for that session. 3. ongoingRequests will be a map of <jobId, InvocationContext> where InvocationContext is the state of each trigger. 4. Managed these states globally by dynamically adding Trigger states into ongoingRequests and whenever the user made a decision(accept or reject), conclude decisions for all the ongoing triggers and clear ongoingRequest, so that a new display session can start later. * address comments
…ngs (aws#4914) * Replace old actions with new actions that have configurable key bindings 1. Accept (Tab) 2. Force Accept (Opt + Tab/Opt + Enter) 3. Navigate to Previous (Opt + [) 4. Navigate to Next (Opt + ]) * put sessionConext as project userdata and remove states of the actions * add popup keybinding hint and settings hyperlink * Addressing comments
1. remove triggerOnIdle type code 2. address comments from previous PR
andrewyuq
force-pushed
the
cw-telemetry-2
branch
from
156159e to
1185acb
Compare
…/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererAutoTriggerService.kt Co-authored-by: Richard Li <[email protected]>
andrewyuq
force-pushed
the
main
branch
3 times, most recently
from
5a466c4 to
5016751
Compare
andrewyuq
force-pushed
the
main
branch
2 times, most recently
from
9788111 to
bdc5544
Compare
andrewyuq
force-pushed
the
main
branch
2 times, most recently
from
df2a345 to
f4d987a
Compare
andrewyuq
pushed a commit
that referenced
this pull request
Apr 23, 2025
Orphaned http request that should be rejected somehow sneaked into the http request event loop while the FAISS index is not ready, causing the workspace LSP process to terminate, which causes the JetBrains IDE to re-initialize the workspace LSP process, which further triggers an infinite loop of log storm that caused slowness (the log loop issue is fixed in aws#5581). Here are the sequence of events that happened: 1. JB starts workspace LSP, the LSP then works on tree sitter parsing to generate repomap. 2. When #1 is in progress, client (user) uses @workspace feature sends a request for vector index query. #1 is usually fast but for 1.4GB repo like https://github.com/elastic/elasticsearch (1.4GB), it takes 6 min. 3. Node js event loop busy, client request #2 is timed out. However, requests is cached at server and it becomes an Orphaned http request. 4. The moment when tree sitter parsing is done, node js event loop SOMEHOW immediately handles the Orphaned request in step 2 at a certain possibility! 5. The vector index is not undefined, it was partially initialized, but it had no chunk inside, query when 0 chunks caused Faiss to crash, which terminated the LSP process. 6. JB saw java.net.ConnectException: Connection refused, it then forces LSP to restart, which restarts the indexing, causing performance issue.
andrewyuq
force-pushed
the
main
branch
2 times, most recently
from
a5ca53f to
9ebb553
Compare
andrewyuq
force-pushed
the
main
branch
2 times, most recently
from
a87a064 to
02cc324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.