-
Notifications
You must be signed in to change notification settings - Fork 97
Redesign #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Redesign #115
Conversation
Add new ui-component module with some early components.
Co-authored-by: Jolanda Verhoef <[email protected]>
Co-authored-by: Thomas Ezan <[email protected]>
Co-authored-by: Caren <[email protected]> Co-authored-by: calren <[email protected]> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Thomas Ezan <[email protected]> Co-authored-by: Mayuri Khinvasara <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Kateryna Semenova <[email protected]> Co-authored-by: lethargicpanda <[email protected]> Co-authored-by: JolandaVerhoef <[email protected]>
…#102) Co-authored-by: Jolanda Verhoef <[email protected]>
Co-authored-by: Caren <[email protected]> Co-authored-by: calren <[email protected]> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Thomas Ezan <[email protected]> Co-authored-by: Mayuri Khinvasara <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Kateryna Semenova <[email protected]> Co-authored-by: lethargicpanda <[email protected]> Co-authored-by: JolandaVerhoef <[email protected]>
Improve loading states for: - Gemini Chatbot - Gemini Image Chatbot - Imagen - Magic selfie
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @lethargicpanda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant redesign of the AI Sample Catalog application, establishing a unified and modern user interface across all demonstrations. The core of this effort is the creation of a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a major redesign of the application, centralizing UI components into a new ui-component
module and giving the app a fresh, modern look. The refactoring is extensive and improves code organization, reusability, and consistency across the different samples. The new UI is more polished and user-friendly.
I've found a critical issue with a sample entry point being incorrect, a duplicate entry in the sample catalog, and a minor issue with a log tag. Please see the detailed comments for each.
title = R.string.gemini_video_metadata_creation_sample_title, | ||
description = R.string.gemini_video_metadata_creation_sample_description, | ||
route = "VideoMetadataCreationScreen", | ||
sampleEntryScreen = { VideoMetadataCreationScreen() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sampleEntryScreen
for the "Video Summarization" sample is pointing to VideoMetadataCreationScreen()
instead of VideoSummarizationScreen()
. This will cause the wrong sample to be opened when selected from the catalog.
sampleEntryScreen = { VideoMetadataCreationScreen() }, | |
sampleEntryScreen = { VideoSummarizationScreen() }, |
SampleCatalogItem( | ||
title = R.string.gemini_video_metadata_creation_sample_title, | ||
description = R.string.gemini_video_metadata_creation_sample_description, | ||
route = "VideoMetadataCreationScreen", | ||
sampleEntryScreen = { VideoMetadataCreationScreen() }, | ||
tags = listOf(SampleTags.GEMINI_FLASH, SampleTags.FIREBASE, SampleTags.MEDIA3), | ||
needsFirebase = true, | ||
keyArt = R.drawable.img_keyart_video_summary, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.