Skip to content

Conversation

lethargicpanda
Copy link
Collaborator

No description provided.

lethargicpanda and others added 26 commits October 1, 2025 21:44
Add new ui-component module with some early components.
Co-authored-by: Caren <[email protected]>
Co-authored-by: calren <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Thomas Ezan <[email protected]>
Co-authored-by: Mayuri Khinvasara <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Kateryna Semenova <[email protected]>
Co-authored-by: lethargicpanda <[email protected]>
Co-authored-by: JolandaVerhoef <[email protected]>
Co-authored-by: Caren <[email protected]>
Co-authored-by: calren <[email protected]>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Thomas Ezan <[email protected]>
Co-authored-by: Mayuri Khinvasara <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Kateryna Semenova <[email protected]>
Co-authored-by: lethargicpanda <[email protected]>
Co-authored-by: JolandaVerhoef <[email protected]>
Improve loading states for:
- Gemini Chatbot
- Gemini Image Chatbot
- Imagen
- Magic selfie
Copy link

google-cla bot commented Oct 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

Summary of Changes

Hello @lethargicpanda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a significant redesign of the AI Sample Catalog application, establishing a unified and modern user interface across all demonstrations. The core of this effort is the creation of a dedicated ui-component module, which encapsulates shared UI elements, theming, and composables. This strategic refactoring not only standardizes the visual presentation but also enhances code maintainability and accelerates future UI development. Each sample application has been meticulously updated to integrate these new components, providing a more polished and consistent user experience.

Highlights

  • UI Component Library: A new ui-component module has been introduced to centralize common UI elements, themes, and composables, ensuring a consistent design system across all AI samples.
  • Unified Design System: All individual AI sample modules have been refactored to utilize the new ui-component library, leading to a cohesive and modern look and feel throughout the application.
  • Adaptive Layouts: The multimodal sample screen now features adaptive layouts, optimizing the user experience across various screen sizes and orientations.
  • Material3 Updates: Dependencies have been updated to the latest Material3 versions, incorporating new features and improvements in Compose UI.
  • Refactored Sample UIs: Extensive refactoring of UI code in all sample modules to replace custom implementations with reusable components from the new ui-component module, improving maintainability and reducing redundancy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a major redesign of the application, centralizing UI components into a new ui-component module and giving the app a fresh, modern look. The refactoring is extensive and improves code organization, reusability, and consistency across the different samples. The new UI is more polished and user-friendly.

I've found a critical issue with a sample entry point being incorrect, a duplicate entry in the sample catalog, and a minor issue with a log tag. Please see the detailed comments for each.

title = R.string.gemini_video_metadata_creation_sample_title,
description = R.string.gemini_video_metadata_creation_sample_description,
route = "VideoMetadataCreationScreen",
sampleEntryScreen = { VideoMetadataCreationScreen() },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The sampleEntryScreen for the "Video Summarization" sample is pointing to VideoMetadataCreationScreen() instead of VideoSummarizationScreen(). This will cause the wrong sample to be opened when selected from the catalog.

Suggested change
sampleEntryScreen = { VideoMetadataCreationScreen() },
sampleEntryScreen = { VideoSummarizationScreen() },

Comment on lines +136 to 144
SampleCatalogItem(
title = R.string.gemini_video_metadata_creation_sample_title,
description = R.string.gemini_video_metadata_creation_sample_description,
route = "VideoMetadataCreationScreen",
sampleEntryScreen = { VideoMetadataCreationScreen() },
tags = listOf(SampleTags.GEMINI_FLASH, SampleTags.FIREBASE, SampleTags.MEDIA3),
needsFirebase = true,
keyArt = R.drawable.img_keyart_video_summary,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This SampleCatalogItem for "Video Metadata Creation" appears to be a duplicate. There is another entry for it just before this one. Please remove the duplicated entry to avoid confusion and redundant code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants