Skip to content

Add static method to grant permissions without needing the TestRule infrastructure in GrantPermissionRule #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add static method to grant permissions without needing the TestRule infrastructure in GrantPermissionRule #2392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions runner/rules/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

**API Changes**

* `GrantPermissionRule` now has a method `#grantImmediately` to grant permissions without going through the `TestRule` infrastructure.

**Breaking API Changes**

**Known Issues**
6 changes: 6 additions & 0 deletions runner/rules/java/androidx/test/rule/GrantPermissionRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,12 @@ public static GrantPermissionRule grant(String... permissions) {
return grantPermissionRule;
}

public static void grantImmediately(String... permissions) {
GrantPermissionRule grantPermissionRule = new GrantPermissionRule();
grantPermissionRule.grantPermissions(permissions);
grantPermissionRule.permissionGranter.requestPermissions();
}

private void grantPermissions(String... permissions) {
Set<String> permissionSet = satisfyPermissionDependencies(permissions);
permissionGranter.addPermissions(permissionSet.toArray(new String[permissionSet.size()]));
Expand Down
Loading