Update PersistableBundleSubject#isEqual to handle arrays #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
piper_826168934
branch
2 times, most recently
from
84451b0 to
3e833c1
Compare
I originally thought MapSubject was handling `Array` types, but the PersistableBundles in the test cases were using the same array reference meaning the tests were incorrect. Updates to just convert the arrays to a list and updates the tests to perform a clone in `getTestBundle`. We could also convert them to a function instead but a shallow copy is sufficient here. PiperOrigin-RevId: 827559640
copybara-service
bot
force-pushed
the
piper_826168934
branch
from
3e833c1 to
54e9296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PersistableBundleSubject#isEqual to handle arrays
I originally thought MapSubject was handling
Arraytypes, but the PersistableBundles in the test cases were using the same array reference meaning the tests were incorrect.Updates to just convert the arrays to a list and updates the tests to perform a clone in
getTestBundle. We could also convert them to a function instead but a shallow copy is sufficient here.