Include tests in build and increase version number to 2 #91
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the application's versioning and ensured that tests are now included as part of the standard build process. This was achieved by incrementing the versionCode and versionName in the Gradle build file and removing the -x test flag from the build scripts.
Highlights
- Version Update: The application's versionCode has been incremented to 2 and versionName updated to "1.0.1" in app/build.gradle.kts.
- Test Inclusion in Builds: The -x test flag, which previously excluded tests from the build process, has been removed from both build.sh and build_presubmit.sh. This change ensures that tests will now run as part of the standard build execution.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to include tests in the build process and increment the application version. The version update in app/build.gradle.kts is correct. However, the changes in the build scripts (build.sh and build_presubmit.sh) are not sufficient to run the tests. I've provided suggestions to correctly include the test execution in the build commands.
| @@ -95,7 +95,7 @@ echo "INFO: Cleaning the project..." | |||
|
|
|||
| # Build the production release bundle without generating a baseline profile. | |||
| echo "INFO: Building the production release bundle..." | |||
| ./gradlew app:bundleRelease app:spdxSbomForRelease -x test -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true | |||
| ./gradlew app:bundleRelease app:spdxSbomForRelease -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true | |||
There was a problem hiding this comment.
Removing the -x test flag alone is not enough to run the tests during the build. The bundleRelease Gradle task does not have a dependency on the test task, so tests will not be executed automatically.
To ensure tests are run, you need to explicitly add the test task to the command.
| ./gradlew app:bundleRelease app:spdxSbomForRelease -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true | |
| ./gradlew test app:bundleRelease app:spdxSbomForRelease -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true |
| @@ -96,7 +96,7 @@ echo "INFO: Cleaning the project..." | |||
|
|
|||
| # Build the production release bundle without generating a baseline profile. | |||
| echo "INFO: Building the production release bundle..." | |||
| ./gradlew app:bundleRelease app:spdxSbomForRelease -x test -x uploadCrashlyticsMappingFileRelease -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true | |||
| ./gradlew app:bundleRelease app:spdxSbomForRelease -x uploadCrashlyticsMappingFileRelease -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true | |||
There was a problem hiding this comment.
Removing the -x test flag alone is not enough to run the tests during the build. The bundleRelease Gradle task does not have a dependency on the test task, so tests will not be executed automatically.
To ensure tests are run, you need to explicitly add the test task to the command.
| ./gradlew app:bundleRelease app:spdxSbomForRelease -x uploadCrashlyticsMappingFileRelease -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true | |
| ./gradlew test app:bundleRelease app:spdxSbomForRelease -x uploadCrashlyticsMappingFileRelease -Pandroid.sdk.path=$ANDROID_HOME -PCI_BUILD=true |
No description provided.