Skip to content

docs(README): call out JDK 17 requirement for AGP #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs(README): call out JDK 17 requirement for AGP #1609

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3005dd
docs(README): call out JDK 17 requirement for AGP
Qandil11 Sep 4, 2025
33f6b71
docs(README): descriptive AGP link + remove extra blank line
Qandil11 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ You can clone this repository or import the
project from Android Studio following the steps
[here](https://developer.android.com/jetpack/compose/setup#sample).

> **Java / JDK**
> Building with recent Android Gradle Plugin versions requires **JDK 17**.
> Android Studio (Flamingo and newer) bundles JDK 17 by default.
> See: https://developer.android.com/studio/releases/gradle-plugin#jdk-17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to provide more context, it's a good practice to use descriptive text for links instead of raw URLs.

Suggested change
> See: https://developer.android.com/studio/releases/gradle-plugin#jdk-17
> See the [AGP release notes](https://developer.android.com/studio/releases/gradle-plugin#jdk-17).



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This extra blank line can be removed to maintain consistent spacing throughout the document. One blank line is sufficient to separate sections.

🧬 Samples
------------

Expand Down