Proposal - Koin Local Setup

[arnaudgiuliani]

In the existing samples that use Koin, we are testing whether Koin has already started. This is quite defensive and not really scaling for the coming examples.

I propose to change to:

• KoinApplication() for a simple Compose entry point in KoinViewModelsActivity.
• koinApplication { } to setup a local Koin instance in KoinModularActivity.

This way, we don't need to check if Koin has been started.

[gemini-code-assist]

Summary of Changes

Hello @arnaudgiuliani, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Koin dependency injection setup within two example activities, KoinModularActivity and KoinViewModelsActivity. The primary goal is to move away from a global Koin context that required defensive checks, towards more isolated and local Koin instances. This change streamlines the configuration process, making the Koin integration in these samples cleaner and more aligned with best practices for modular and composable applications.

Highlights

• Koin Setup Simplification: The pull request simplifies Koin initialization by removing defensive checks for existing Koin instances, streamlining the setup process.
• Local Koin Instances: The KoinModularActivity now utilizes a local Koin instance, defined within a companion object using koinApplication { }, ensuring isolated dependency management.
• Compose Koin Application: The KoinViewModelsActivity adopts the KoinApplication() composable to establish a Compose-specific Koin entry point, integrating Koin directly into the UI hierarchy.
• Dependency Update: The Koin library version has been updated from 4.2.0-alpha2 to 4.2.0-beta2 in the libs.versions.toml file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully refactors the Koin setup in KoinModularActivity and KoinViewModelsActivity to use local Koin contexts instead of a global one. This is an excellent improvement that makes the examples more isolated and robust, preventing potential side effects between different samples. The implementation uses modern Koin APIs like koinApplication and the KoinApplication composable correctly. My feedback includes one suggestion to improve code organization for better long-term maintainability.

[gemini-code-assist]

For improved readability and code organization, it's a common convention to declare top-level properties like appModule before the classes that use them. Consider moving this module definition to the top of the file, after the import statements. This allows developers reading the file to see the dependencies at a glance before diving into the component's implementation.