build: migrate deprecated kotlinOptions to compilerOptions#201
build: migrate deprecated kotlinOptions to compilerOptions#201afaqkhan707 wants to merge 6 commits intoandroid:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @afaqkhan707, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the build configuration to align with the latest Kotlin Gradle DSL recommendations. It replaces a deprecated method for specifying the JVM target with the modern Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly migrates app/build.gradle.kts from the deprecated kotlinOptions.jvmTarget to the new compilerOptions API. This is a good improvement to keep the project's build scripts modern. I've left one suggestion to use the type-safe enum constant for setting the JVM target. Additionally, I noticed that the advanceddeeplinkapp/build.gradle.kts file still uses the old kotlinOptions. To ensure consistency across the project and eliminate all deprecation warnings, I recommend applying the same update to that module as well.
app/build.gradle.kts
Outdated
|
|
||
| kotlin{ | ||
| compilerOptions{ | ||
| jvmTarget = JvmTarget.fromTarget("11") |
|
@afaqkhan707 Thanks for your contribution. In order to accept this, we need you to sign the CLA. If we don't hear back within 1 week, this PR will be closed. |
This change replaces the deprecated
kotlinOptions.jvmTargetwith thenew
kotlin { compilerOptions { jvmTarget = ... } }API.