Add nav2 to nav3 snippets markdown file #66
Conversation
Publishing snippest that show some examples of converting common patterns in nav2 to nav3.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jbw0033, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new markdown document, Nav2ToNav3Snippets.md, which serves as a comprehensive guide for migrating Android navigation patterns from Navigation 2 to Navigation 3. The document specifically targets Compose-based applications and provides side-by-side code snippets to demonstrate how common navigation functionalities are implemented in both versions, aiding developers in the transition process.
Highlights
- New Migration Guide Document: A new markdown file, Nav2ToNav3Snippets.md, has been added to provide a detailed guide for transitioning navigation patterns from Navigation 2 to Navigation 3.
- Comparative Code Examples: The document offers clear, comparative code snippets for a wide array of navigation functionalities, illustrating both Navigation 2 and Navigation 3 implementations side-by-side.
- Comprehensive Coverage of Navigation Patterns: The snippets cover essential navigation concepts including NavController usage, graph construction, basic navigation, back stack manipulation (pop, pop up to), state saving, type-safe routes, dialog and activity navigation, encapsulation, nested navigation, animations, shared element transitions, activity transitions, deep linking, conditional navigation, circular navigation, ViewModel integration, and testing.
- Compose-Only Focus: All provided code examples are specifically tailored for Compose-only implementations, offering relevant guidance for modern Android application development.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds a new markdown file with code snippets to help developers migrate from Navigation 2 to Navigation 3. This is a valuable addition. However, I've found several issues in the provided code snippets, including syntax errors, logical flaws, and the use of non-standard helper functions without explanation. These issues could confuse users or lead to incorrect implementations. My review includes specific comments and suggestions to correct these problems and improve the overall quality and accuracy of the guide.
Publishing snippets that show some examples of converting common patterns in nav2 to nav3.