clang-format the world. #1112
Merged
clang-format the world. #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be done by CI but we ripped that out since there wasn't any good way to ensure that CI and and local workflows were using the same clang-format. Back when it was in CI, the pointer alignment was configured incorrectly (we used the Google style presets, but those are alignment preserving rather than actually style enforcing). Reformat everything since the .clang-format file has changed since then so I stop including so many unrelated edits in my commits.
enh-google
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be done by CI but we ripped that out since there wasn't any good way to ensure that CI and and local workflows were using the same clang-format. Back when it was in CI, the pointer alignment was configured incorrectly (we used the Google style presets, but those are alignment preserving rather than actually style enforcing). Reformat everything since the .clang-format file has changed since then so I stop including so many unrelated edits in my commits.