Skip to content

Commit bbdc62c

Browse files
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
2 parents 02bf1ac + f6bdba0 commit bbdc62c

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,12 @@ import com.google.samples.apps.nowinandroid.core.model.data.UserNewsResource
3131
* [UserNewsResource]s.
3232
*
3333
* [onToggleBookmark] defines the action invoked when a user wishes to bookmark an item
34-
* [onItemClick] optional parameter for action to be performed when the card is clicked. The
35-
* default action launches an intent matching the card.
34+
* When a news resource card is tapped it will open the news resource URL in a Chrome Custom Tab.
3635
*/
3736
fun LazyListScope.userNewsResourceCardItems(
3837
items: List<UserNewsResource>,
3938
onToggleBookmark: (item: UserNewsResource) -> Unit,
4039
onNewsResourceViewed: (String) -> Unit,
41-
onItemClick: ((item: UserNewsResource) -> Unit)? = null,
4240
onTopicClick: (String) -> Unit,
4341
itemModifier: Modifier = Modifier,
4442
) = items(
@@ -59,10 +57,7 @@ fun LazyListScope.userNewsResourceCardItems(
5957
analyticsHelper.logNewsResourceOpened(
6058
newsResourceId = userNewsResource.id,
6159
)
62-
when (onItemClick) {
63-
null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)
64-
else -> onItemClick(userNewsResource)
65-
}
60+
launchCustomChromeTab(context, resourceUrl, backgroundColor)
6661
onNewsResourceViewed(userNewsResource.id)
6762
},
6863
onTopicClick = onTopicClick,

0 commit comments

Comments
 (0)