Prevent infinite growing fts-database #1268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaehwa-Noh
added a commit
to Jaehwa-Noh/Jaehwa-Noh
that referenced
this pull request
Mar 11, 2024
JoseAlcerreca
previously requested changes
Mar 25, 2024
...androidTest/kotlin/com/google/samples/apps/nowinandroid/core/database/dao/TopicFtsDaoTest.kt
Outdated
Show resolved
Hide resolved
...n/com/google/samples/apps/nowinandroid/core/testing/database/NewsResourceEntitiesTestData.kt
Outdated
Show resolved
Hide resolved
...idTest/kotlin/com/google/samples/apps/nowinandroid/core/data/SearchContentsRepositoryTest.kt
Outdated
Show resolved
Hide resolved
...Test/kotlin/com/google/samples/apps/nowinandroid/core/database/dao/NewsResourceFtsDaoTest.kt
Outdated
Show resolved
Hide resolved
keyboardsurfer
approved these changes
Dec 9, 2024
Contributor
Author
|
@keyboardsurfer I merged it with latest main branch. Kindly take a look. |
Contributor
Author
|
@dturner @keyboardsurfer This PR had been passed the CI tests. |
Jaehwa-Noh
changed the title
Change-Id: Iae763a3efc8a00c7ffda252b2d9f8d9f2bf3667b
Change-Id: Id8fd51a4542e8cb22645d36ec507af4d7f02489d
Change-Id: I25c338839275cd43db92e8a9e0d45bed8776f316
Change-Id: I234ecf3b50b8c327d919d0fc4a0d489e5101f690
Change-Id: I68d5a3d77a5f0d1fdc1a84a6fbb1221a674d9793
Change-Id: I4c3e0c2f2e063dec18c07bf2c81c098787956438
Change-Id: I09fa6c445b142072e9fba6923fbd51fbe372cacf
Jaehwa-Noh
force-pushed
the
optimize-ftsdatabase
branch
from
db62cf6 to
b6f2647
Compare
Change-Id: I52c1595b039501f9c123dda4425ecba687ad7ac6
Change-Id: Ibd0a8d67fd3d73435761ca2c495265eaf51a06d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
FTS Database table has hidden column which is rowId as Primary key.
So, the same entity was not replaced with old entity which is already in the database, because of we can't set rowId manually.
So that I added check logic that it is already in the database before insert new one which came from the network.
Fixes #1267