Skip to content

Conversation

@Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented May 14, 2024

What I have done and why

In the PR #1048 the AndroidTest has been removed, so that there is no need the testInstrumentationRunner anymore.

Also need to remove the dependency of AndroidTest.

Change-Id: I1c3d0b8504ec4129f18fd5096f543a1bf90e21d3
@Jaehwa-Noh Jaehwa-Noh marked this pull request as draft May 14, 2024 10:07
Change-Id: I0d362778fe10ea064a3f5eab1a8a5737802ff526
@Jaehwa-Noh Jaehwa-Noh changed the title Remove defaultConfig testInstrumentationRunner. Remove AndroidTest dependency and runner in :designsystem May 14, 2024
@Jaehwa-Noh Jaehwa-Noh marked this pull request as ready for review May 14, 2024 10:23
@keyboardsurfer
Copy link
Member

Thanks for your PR. Currently there are conflicts that need to be resolved before we can move on to possibly accepting your contribution. Please resolve the conflicts.

Change-Id: I5535315c6159e3b70e8591b60a50d2e0607efe97

# Conflicts:
#	core/designsystem/build.gradle.kts
@Jaehwa-Noh
Copy link
Contributor Author

@keyboardsurfer I've resolved a conflict.

@dturner dturner merged commit 69f11b9 into android:main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants