Update to material3-adaptive 1.1 #1642
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvanyo
force-pushed
the
av/material3-adaptive-1.1
branch
from
58b1387 to
074c035
Compare
alexvanyo
force-pushed
the
av/material3-adaptive-1.1
branch
2 times, most recently
from
b85f29e to
4594d18
Compare
Change-Id: I4b3b68face17149ab87135df28baa41cd5bacb0f
Change-Id: I5fba15921520bc83b13601fa82ae71457d875805
alexvanyo
force-pushed
the
av/material3-adaptive-1.1
branch
2 times, most recently
from
93a74b6 to
2553411
Compare
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
alexvanyo
force-pushed
the
av/material3-adaptive-1.1
branch
from
2553411 to
e25b363
Compare
Change-Id: I8e881bb2cf549303be8612732bfb7df7555096aa
alexvanyo
force-pushed
the
av/material3-adaptive-1.1
branch
from
5021a1c to
502c719
Compare
dturner
approved these changes
Mar 11, 2025
Collaborator
dturner
left a comment
dturner
left a comment
There was a problem hiding this comment.
LGTM with a couple of very minor things. Might be good to have someone else more familiar with these APIs review though.
...n/kotlin/com/google/samples/apps/nowinandroid/ui/interests2pane/InterestsListDetailScreen.kt
Outdated
Show resolved
Hide resolved
dturner
reviewed
Mar 11, 2025
...n/kotlin/com/google/samples/apps/nowinandroid/ui/interests2pane/InterestsListDetailScreen.kt
Outdated
Show resolved
Hide resolved
Change-Id: I44696efe11f8d660bb7c9dc41ade6927ce15798b
Change-Id: I5869404bc66d878030faf1ae2d5b95cc27ce67b4
Contributor
Author
|
@dturner I am unable to resolve all comments that were left on this PR much earlier, I'm going to close and reopen it in a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates material3-adaptive to 1.1, to try out the new features in Now in Android.
The main new feature is pane expansion, to allow resizing the panes with a drag handle.
To accomplish this, I've removed the nested
NavHostsetup, and replaced it with assisted injectedTopicViewModels for each specific topic screens. This comes with a trade-off, that while on the list-detail interests screen, swapping between different topics will build up manyViewModels in memory.