Update screenshot dependencies including robolectric, roborazzi #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
commented
Nov 17, 2024
app/src/testDemo/screenshots/compactWidth_expandedHeight_showsNavigationBar.png
Show resolved
Hide resolved
yschimke
commented
Nov 17, 2024
yschimke
commented
Nov 17, 2024
yschimke
changed the title
Contributor
Author
|
Updating screenshots on a fork PR yschimke#1 |
yschimke
changed the title
Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi. Also, update Screenshot Tests with sdk version 35 for better screenshot testing.
yschimke
force-pushed
the
latest_roborazzi
branch
from
924b191 to
0dd9987
Compare
Contributor
Author
|
@SimonMarquis good call, the text changes are gone by sticking with the same sdk. |
Collaborator
|
The Compose BOM bump from 2024.09.00 to 2024.10.01 is what is causing the screenshot changes. This is caused by aosp/3317353. Happy for these to be merged since there are no obvious changes to the UI. |
dturner
approved these changes
Nov 18, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi.
There have been a bunch of useful fixes in Compose, Robolectric and Roborazzi, so move towards these.
The motivation is I'd like to start using some extra roborazzi features and want to decouple this from functionality changes.