Upgrade kotlin and ksp to latest stable versions #1704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturner
approved these changes
Nov 19, 2024
Collaborator
|
Thanks for this. Just a note for the future, if you update dependencies please also run |
Collaborator
|
We've spent quite a bit of time updating library dependencies recently. Both Kotlin and KSP have been updated as part of updates elsewhere. |
kaeawc
deleted the
kaeawc/upgrade-kotlin-and-ksp-for-metaspace-leak-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
Upgraded Kotlin & KSP so this project can receive a KSP memory leak fix google/ksp#2073
I profiled NowInAndroid with a dev local build of KSP to originally test the fix which made it into release 2.0.21-1.0.26. I just profiled it again before and after the upgrade and can verify the metaspace leak is fixed by this change.