Add androidx.lint:lint-gradle to build-logic #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@alexvanyo would you mind fixing the conflicts please? |
alexvanyo
force-pushed
the
av/add-androidx-lint-gradle
branch
2 times, most recently
from
4ab227e to
78016f2
Compare
Contributor
Author
|
Rebased! |
Change-Id: I95a0e1f5ae5d78d3725ab20031fe268515a50153
alexvanyo
force-pushed
the
av/add-androidx-lint-gradle
branch
from
78016f2 to
e4681fc
Compare
dturner
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
androidx.lint:lint-gradlelibrary as a lint check library for thebuild-logicmodule, which lints the convention plugin implementation against common issues.This PR also fixes the existing issues we had, so that
./gradlew check -p build-logic, which runs the lint checks, passes.Fixes #1676