Skip to content

Conversation

@LinX64
Copy link
Contributor

@LinX64 LinX64 commented Dec 16, 2024

This uses the proper task for the NightlyBaselineProfiles build script.

  1. First, it sets up the GMD and creates a snapshot
  2. Generates the baseline profile and startup using :app:generateReleaseBaselineProfile

Two steps were missing in the current script.

@keyboardsurfer @dturner - Would appreciate your thoughts on this.

@LinX64 LinX64 marked this pull request as ready for review December 16, 2024 11:14
@LinX64 LinX64 force-pushed the feature/adding-baseline-and-startup-profile-to-the-codebase-in-nightly-builds branch from e8365fa to a7d6f99 Compare December 16, 2024 11:17
@LinX64 LinX64 force-pushed the feature/adding-baseline-and-startup-profile-to-the-codebase-in-nightly-builds branch from a7d6f99 to aef1bcf Compare December 16, 2024 11:19
@LinX64
Copy link
Contributor Author

LinX64 commented Dec 16, 2024

@keyboardsurfer Unfortunately, I couldn't test this on this repo as it requires some approvals. But in case you wanted to see how that might behave, here is a sample: https://github.com/LinX64/Baseline

@keyboardsurfer
Copy link
Member

Baseline Profiles do not need to be part of the repository's source code. We have chosen to only generate BP for release builds (and as nightly as continuous check that nothing is broken). Over time this saves a lot of data when checking out the repository.

@LinX64
Copy link
Contributor Author

LinX64 commented Dec 16, 2024

Baseline Profiles do not need to be part of the repository's source code. We have chosen to only generate BP for release builds (and as nightly as continuous check that nothing is broken). Over time this saves a lot of data when checking out the repository.

I understand the reason why you kept it like that, so thanks. However, I should say that the NightlyBaselineProfiles script does not properly check for the purpose you mentioned.

as nightly as continuous check that nothing is broken

For this purpose, I'd have:

- name: Generate Baseline Profile
        run: ./gradlew :app:generateReleaseBaselineProfile
          -Pandroid.testInstrumentationRunnerArguments.androidx.benchmark.enabledRules=baselineprofile
          -Pandroid.testoptions.manageddevices.emulator.gpu="swiftshader_indirect"
          --stacktrace

To verify if everything works as expected.

@LinX64 LinX64 changed the title Feature / Added baseline and startup profile generation and push in Nightly build Feature / Added baseline and startup profile generation Dec 17, 2024
@keyboardsurfer keyboardsurfer merged commit 8f196e1 into android:main Dec 18, 2024
5 checks passed
keyboardsurfer added a commit that referenced this pull request Dec 20, 2024
keyboardsurfer added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants