NavHost replaced with if statement #1823
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvanyo
reviewed
Feb 4, 2025
| ) { topicIUState, newsUIState -> | ||
| _topicUIState.update { topicIUState } | ||
| _newsUIState.update { newsUIState } | ||
| }.stateIn(viewModelScope) |
Contributor
There was a problem hiding this comment.
The combines for old topicIds will continue to run right now, since these won't be cancelled if the topic id changes.
| viewModel: TopicViewModel = hiltViewModel(), | ||
| viewModel: TopicViewModel = hiltViewModel() | ||
| ) { | ||
| viewModel.updateTopic(topicId) |
Contributor
There was a problem hiding this comment.
This line feels the strangest with this usage, since we are reusing a single instance of the ViewModel scoped to the overall navigation entry with many different topicIds that we are swapping between.
One side-effect is that we can't display two different versions of the TopicScreen at the same time, which might be ideal to animate between two different selected topics.
Contributor
|
Thank you for proposing this for consideration - #1835 removed the nested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed NavHost for ListDetailPaneScaffold
Creating NavHost object every time user goes to a new interest object is expensive. We may do it with more effective way. Especially when there are only two possible composable choices that can be switched with the only if statement.