Skip to content

Remove redundant output from the Badging task #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jaehwa-Noh wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −10
Open

Remove redundant output from the Badging task #2000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Badging.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,12 @@ import com.android.build.api.variant.ApplicationAndroidComponentsExtension
import com.google.common.truth.Truth.assertWithMessage
import org.gradle.api.DefaultTask
import org.gradle.api.Project
import org.gradle.api.file.DirectoryProperty
import org.gradle.api.file.RegularFileProperty
import org.gradle.api.provider.Property
import org.gradle.api.tasks.CacheableTask
import org.gradle.api.tasks.Copy
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.InputFile
import org.gradle.api.tasks.OutputDirectory
import org.gradle.api.tasks.OutputFile
import org.gradle.api.tasks.PathSensitive
import org.gradle.api.tasks.PathSensitivity
Expand Down Expand Up @@ -75,12 +73,6 @@ abstract class GenerateBadgingTask : DefaultTask() {
@CacheableTask
abstract class CheckBadgingTask : DefaultTask() {

// In order for the task to be up-to-date when the inputs have not changed,
// the task must declare an output, even if it's not used. Tasks with no
// output are always run regardless of whether the inputs changed
@get:OutputDirectory
abstract val output: DirectoryProperty

@get:PathSensitive(PathSensitivity.NONE)
@get:InputFile
abstract val goldenBadging: RegularFileProperty
Expand Down Expand Up @@ -130,7 +122,7 @@ fun Project.configureBadgingTasks(
"${baseExtension.buildToolsVersion}/" +
SdkConstants.FN_AAPT2,
)
}
},
)
badging = project.layout.buildDirectory.file(
"outputs/apk_from_bundle/${variant.name}/${variant.name}-badging.txt",
Expand All @@ -152,7 +144,7 @@ fun Project.configureBadgingTasks(

this.updateBadgingTaskName = updateBadgingTaskName

output = project.layout.buildDirectory.dir("intermediates/$checkBadgingTaskName")
outputs.upToDateWhen { true }

}
}
Expand Down
Loading