Implement settings feature as a Nav3 dialog screen #2043
Conversation
This makes the `:feature:settings` behave like any other feature with api/impl split.
Summary of ChangesHello @SimonMarquis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's modularity and navigation consistency by refactoring the settings feature. It transitions the settings UI from a standalone dialog to a fully integrated Nav3 dialog screen, aligning it with the established API/implementation architecture. This change streamlines how settings are accessed and managed within the application's navigation flow, improving overall code organization and maintainability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| /** | ||
| * Current [NavKey] but ignores [DialogNavKey]s that could be added on top. | ||
| */ | ||
| val currentKeyIgnoringDialogs: NavKey by derivedStateOf { currentSubStack.last { it !is DialogNavKey } } |
There was a problem hiding this comment.
@dturner I'm open to suggestions on how to properly support this.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a great refactoring of the settings feature. It successfully migrates the settings dialog to a full-fledged feature module with an api/impl split, integrating it cleanly with the Nav3 navigation library as a dialog screen. The introduction of DialogNavKey and currentKeyIgnoringDialogs in the core navigation module is a smart, generic solution for handling dialogs over other screens. The changes are well-structured and follow the existing architecture of the application. I have one minor suggestion regarding code style for consistency.
1 participant
This makes the
:feature:settingsbehave like any other feature with api/impl split.