Skip to content

Update TFLite implementation with ByteBufferGlEffect #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calren merged 3 commits into from
Nov 30, 2024
Merged

Update TFLite implementation with ByteBufferGlEffect #209

calren merged 3 commits into from
Nov 30, 2024

Conversation

@droid-girl
Copy link
Contributor

@droid-girl droid-girl commented Oct 24, 2024

Update TFLite/RTLite effect with the new ByteBufferGlEffect

@calren calren self-requested a review October 24, 2024 18:39
@calren
Copy link
Contributor

calren commented Oct 24, 2024

can we also update the ultrahdr dependency?

it looks like the test failures from CI are valid:

Dependency 'androidx.media3:media3-datasource:1.5.0-alpha01' requires libraries and applications that
           depend on it to compile against version 35 or later of the
           Android APIs.
     
           :samples:media:ultrahdr is currently compiled against android-34.

@calren calren mentioned this pull request Nov 18, 2024
Merged
@calren
Copy link
Contributor

calren commented Nov 18, 2024

i just merged #215. Do you mind rebasing frommain to see if the build passes now? Thanks!

@Joseantoniomaypuc
Copy link

Joseantoniomaypuc commented Nov 18, 2024

Acabo de fusionar el n.° 215. ¿Te importaría volver a crearlo mainpara ver si la compilación funciona correctamente? ¡Gracias!

Si claro

@droid-girl droid-girl force-pushed the transformer-style-transfer branch from c35ee9c to fe1f0a1 Compare November 28, 2024 22:48
@droid-girl
Copy link
Contributor Author

droid-girl commented Nov 28, 2024

Rebased, I do not see any tests running

@calren
Copy link
Contributor

calren commented Nov 30, 2024

thanks for rebasing! i think the tests don't run until a reviewer initially approves it. i kicked it off and looks like the build passed!

@calren calren merged commit 20c7a4e into android:main Nov 30, 2024
2 checks passed
yrezgui pushed a commit that referenced this pull request Mar 10, 2025
@droid-girl @yrezgui
Update TFLite implementation with ByteBufferGlEffect (#209)
813f48c 
* Update TFLite implementation with ByteBufferGlEffect

* Update media3 version

* Update media3 dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calren calren calren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@droid-girl @calren @Joseantoniomaypuc