Skip to content

Refresh tracker icon assets #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alabiaga merged 1 commit into from
May 21, 2025
Merged

Refresh tracker icon assets #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed samples/user-interface/live-updates/src/main/res/drawable/check_circle.png
View file
Open in desktop
Binary file not shown.
15 changes: 15 additions & 0 deletions samples/user-interface/live-updates/src/main/res/drawable/check_circle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:viewportWidth="24"
android:viewportHeight="24">

<path
android:fillColor="#9d75b1"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fill color #9d75b1 is hardcoded here. For improved maintainability, consistency, and easier theming, it's generally a good practice to define such colors in res/values/colors.xml.
For example, you could define:

<!-- in res/values/colors.xml -->
<color name="tracker_icon_background_purple">#9d75b1</color>

And then reference it in the drawable as android:fillColor="@color/tracker_icon_background_purple".

Would it be feasible to centralize this color definition?

android:pathData="M0,4 A4,4 0 0,1 4,0 H20 A4,4 0 0,1 24,4 V20 A4,4 0 0,1 20,24 H4 A4,4 0 0,1 0,20 Z" />

<path
android:fillColor="#000000"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fill color #000000 (black) is hardcoded. While android:fillColor="@android:color/black" is an option for standard black, if this specific black is part of your app's design palette for icons, defining it in colors.xml (e.g., <color name="icon_foreground_primary">#000000</color>) and referencing it here (e.g., android:fillColor="@color/icon_foreground_primary") would offer better consistency and maintainability. What are your thoughts on this approach?

android:pathData="M9,16.17L4.83,12l-1.42,1.41L9,19 21,7l-1.41,-1.41z" />

</vector>
Binary file removed samples/user-interface/live-updates/src/main/res/drawable/delivery_car.png
View file
Open in desktop
Binary file not shown.
Binary file removed samples/user-interface/live-updates/src/main/res/drawable/delivery_truck.png
View file
Open in desktop
Binary file not shown.
15 changes: 15 additions & 0 deletions samples/user-interface/live-updates/src/main/res/drawable/delivery_truck.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:viewportWidth="960"
android:viewportHeight="960">

<path
android:fillColor="#9d75b1"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fill color #9d75b1 is hardcoded. As mentioned for other drawables, consider defining this as a color resource in colors.xml (e.g., <color name="tracker_icon_background_purple">#9d75b1</color>) and referencing it via android:fillColor="@color/tracker_icon_background_purple". This promotes consistency and makes future color updates easier. Is this something that can be adopted here?

android:pathData="M0,160 A160,160 0 0,40 160,0 H800 A160,160 0 0,40 960,160 V800 A160,160 0 0,40 800,960 H160 A160,160 0 0,40 0,800 Z" />
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The pathData for this rounded rectangle background appears to be malformed. The arc command A (e.g., in A160,160 0 0,40 160,0) uses a sweep-flag value of 40 (the second number in 0,40). However, the sweep-flag must be either 0 or 1.

This will likely lead to parsing errors or incorrect rendering of the drawable. Assuming the intention is a standard rounded rectangle similar to the one in check_circle.xml (which uses 0,1 for large-arc-flag,sweep-flag respectively), this path needs correction.

Could you please verify the intended path and update the flags accordingly? A common configuration for such arcs is large-arc-flag=0 and sweep-flag=1.

        android:pathData="M0,160 A160,160 0 0,1 160,0 H800 A160,160 0 0,1 960,160 V800 A160,160 0 0,1 800,960 H160 A160,160 0 0,1 0,800 Z" />


<path
android:fillColor="#000000"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fill color #000000 is hardcoded. For better maintainability, consider using a color resource from colors.xml. This could be @android:color/black if appropriate, or a custom defined color like <color name="icon_foreground_primary">#000000</color> referenced as android:fillColor="@color/icon_foreground_primary". Would this be a suitable change?

android:pathData="M280,800Q230,800 195,765Q160,730 160,680L60,680L78,600L191,600Q208,581 231,570.5Q254,560 280,560Q306,560 329,570.5Q352,581 369,600L536,600L620,240L182,240L186,223Q192,195 213.5,177.5Q235,160 264,160L720,160L683,320L800,320L920,480L880,680L800,680Q800,730 765,765Q730,800 680,800Q630,800 595,765Q560,730 560,680L400,680Q400,730 365,765Q330,800 280,800ZM637,520L830,520L834,499L760,400L665,400L637,520ZM618,247L620,240L620,240L536,600L536,600L538,593L538,593L572,447L572,447L618,247ZM20,533L40,453L260,453L240,533L20,533ZM100,387L120,307L380,307L360,387L100,387ZM280,720Q297,720 308.5,708.5Q320,697 320,680Q320,663 308.5,651.5Q297,640 280,640Q263,640 251.5,651.5Q240,663 240,680Q240,697 251.5,708.5Q263,720 280,720ZM680,720Q697,720 708.5,708.5Q720,697 720,680Q720,663 708.5,651.5Q697,640 680,640Q663,640 651.5,651.5Q640,663 640,680Q640,697 651.5,708.5Q663,720 680,720Z" />

</vector>
Binary file removed samples/user-interface/live-updates/src/main/res/drawable/shopping_bag.png
View file
Open in desktop
Binary file not shown.
15 changes: 15 additions & 0 deletions samples/user-interface/live-updates/src/main/res/drawable/shopping_bag.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:viewportWidth="960"
android:viewportHeight="960">

<path
android:fillColor="#9d75b1"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fill color #9d75b1 is hardcoded. To enhance maintainability and ensure color consistency, it's advisable to define this in colors.xml (e.g., as <color name="tracker_icon_background_purple">#9d75b1</color>) and use android:fillColor="@color/tracker_icon_background_purple" here. Could this be refactored?

android:pathData="M0,160 A160,160 0 0,40 160,0 H800 A160,160 0 0,40 960,160 V800 A160,160 0 0,40 800,960 H160 A160,160 0 0,40 0,800 Z" />
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to delivery_truck.xml, the pathData for this rounded rectangle background also appears to be malformed. The arc command A (e.g., in A160,160 0 0,40 160,0) uses an invalid sweep-flag value of 40. This flag must be 0 or 1.

This will likely cause rendering issues. If this is intended to be a standard rounded rectangle, the flags need to be corrected (e.g., to 0,1 for large-arc-flag,sweep-flag).

Could you please review and correct this path data?

        android:pathData="M0,160 A160,160 0 0,1 160,0 H800 A160,160 0 0,1 960,160 V800 A160,160 0 0,1 800,960 H160 A160,160 0 0,1 0,800 Z" />


<path
android:fillColor="#000000"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fill color #000000 is hardcoded. Using a color resource (e.g., @android:color/black or a custom one like @color/icon_foreground_primary defined in colors.xml) would be more maintainable. Is it possible to make this change?

android:pathData="M336,840Q245,840 182.5,777.5Q120,715 120,624Q120,586 133,550Q146,514 170,485L312,314L215,120L745,120L648,314L790,485Q814,514 827,550Q840,586 840,624Q840,715 777,777.5Q714,840 624,840L336,840ZM480,640Q447,640 423.5,616.5Q400,593 400,560Q400,527 423.5,503.5Q447,480 480,480Q513,480 536.5,503.5Q560,527 560,560Q560,593 536.5,616.5Q513,640 480,640ZM385,280L575,280L615,200L345,200L385,280ZM336,760L624,760Q681,760 720.5,720.5Q760,681 760,624Q760,600 751.5,577.5Q743,555 728,537L581,360L380,360L232,536Q217,554 208.5,577Q200,600 200,624Q200,681 239.5,720.5Q279,760 336,760Z" />

</vector>
Loading