Skip to content

Conversation

@alabiaga
Copy link
Member

  • add new permission in manifest
  • add new notification permission using NotificationCompat lib
  • add logging for understanding app and notification promotion eligibility

alabiaga added 2 commits June 26, 2025 10:07
Change-Id: I6d1c1c9a1701f08eea752140d3e9bd073e131438
Change-Id: If5f7d557d31bb54f8ffccf2cc03ea3d7bdffad43
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @alabiaga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Live Update sample to reflect new eligibility changes for promoted notifications. It includes adding necessary permissions, migrating to the NotificationCompat library, and adding logging for debugging purposes. The coreKtx dependency was also updated.

Highlights

  • Permissions: Added the POST_PROMOTED_NOTIFICATIONS permission to the manifest to enable live update eligibility.
  • Notification Library: Migrated from the deprecated android.app.Notification to the NotificationCompat library for creating notifications.
  • Logging: Added logging statements to understand app and notification promotion eligibility, specifically checking canPostPromotedNotifications() and hasPromotableCharacteristics().
  • Core KTX Update: Updated the coreKtx dependency to version 1.17.0-alpha01 in gradle/libs.versions.toml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the Live Update sample to reflect new eligibility changes by adding a new permission in the manifest, adding a new notification permission using the NotificationCompat library, and adding logging for understanding app and notification promotion eligibility. Several improvements can be made, including removing unnecessary imports, simplifying code by removing unnecessary calls to toIcon(appContext), using val for the notificationBuilder, and adding the @RequiresApi annotation to the start function.

Change-Id: I67dc7d2122f0193e1271a9c43f0e457e1d42f4d1
@ashnohe ashnohe self-requested a review June 26, 2025 16:47
@alabiaga alabiaga changed the title Update Live Update sample to reflect new eligibility changes Update sample to reflect new eligibility changes Jun 26, 2025
alabiaga added 6 commits June 26, 2025 15:46
Change-Id: Ia088d7ee170ea213d414e7fda4986d26dd230f98
Change-Id: I18874d30eb9ba9ab067a7c09ebdf701c56b28707
Change-Id: Ibd331a63e84392a2801c917c7d8a15215ccc9313
Change-Id: Ieecb65837f4b645ef89e7b54fd30af23040cbcaa
Change-Id: Ic43b86f2d863fbe183a995cd6ac0edc32d4456de
Change-Id: Id3f859d30abb606ed2d2c248c3fffc193426bb9a
@alabiaga alabiaga merged commit 16a3e03 into android:main Jun 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants