Skip to content

List w multiple item types #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 25, 2024
Merged

List w multiple item types #344

merged 11 commits into from
Sep 25, 2024

Conversation

@thedmail
Copy link
Contributor

No description provided.

thedmail and others added 9 commits September 13, 2024 13:14
@thedmail
Attempts to update BNR sample for "Multiple Item Types in a List" Qui…
81ff0ae 
…ckGuide page at https://developer.android.com/quick-guides/content/build-list-multiple-item-types?hl=en
@thedmail
Attempts to update BNR sample for "Multiple Item Types in a List" Qui…
75cb794 
…ckGuide page at https://developer.android.com/quick-guides/content/build-list-multiple-item-types?hl=en
@thedmail
Attempts to update BNR sample for "Multiple Item Types in a List" Qui…
fbbb764 
…ckGuide page at https://developer.android.com/quick-guides/content/build-list-multiple-item-types?hl=en
@thedmail @github-actions
Apply Spotless
a8d55ea
@thedmail
Code snippet for Quick Guide at https://developer.android.com/quick-g…
65ff1b2 
…uides/content/build-list-multiple-item-types?hl=en
@thedmail
Merge remote-tracking branch 'origin/lazily-load-lists' into lazily-l…
2275492 
…oad-lists
@thedmail @github-actions
Apply Spotless
471be65
@thedmail
Code snippet for Quick Guide at https://developer.android.com/quick-g…
28d8fab 
…uides/content/build-list-multiple-item-types?hl=en
@thedmail
Merge remote-tracking branch 'origin/list-w-multiple-item-types' into…
6bbee8e 
… list-w-multiple-item-types
@thedmail thedmail requested a review from riggaroo September 14, 2024 00:33
riggaroo
riggaroo reviewed Sep 15, 2024
View reviewed changes
compose/snippets/src/main/java/com/example/compose/snippets/lists/ListWithMultipleItemTypes.kt

@Composable
fun ListWithMultipleItems(messages: List<Any>) {
LazyColumn {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need the surrounding snippet comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

riggaroo
riggaroo requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs surrounding tags for rendering in DAC

@snippet-bot
Copy link

snippet-bot bot commented Sep 23, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@thedmail thedmail merged commit 0479c74 into main Sep 25, 2024
5 checks passed
@riggaroo riggaroo deleted the list-w-multiple-item-types branch December 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riggaroo riggaroo riggaroo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thedmail @riggaroo