Skip to content

Conversation

@JonEckenrode
Copy link
Contributor

No description provided.

@JonEckenrode JonEckenrode changed the title Created activity_main.xml for activity embedding snippets. Added activity embedding snippets. Mar 14, 2025
@JonEckenrode JonEckenrode changed the title Added activity embedding snippets. Add activity embedding snippets. Mar 14, 2025
@snippet-bot
Copy link

snippet-bot bot commented Mar 18, 2025

Here is the summary of changes.

You are about to add 50 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

media3 = "1.5.1"
# @keep
minSdk = "21"
minSdk = "24"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably not be bumped up so high, as it bumps up all samples.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you need this for a specific sample, consider creating a new module that has this as the minimum requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored minSdk to 21. Added @RequiresApi(api=VERSION_CODES.N) to enclosing method of snippets.

@JonEckenrode JonEckenrode requested a review from riggaroo March 20, 2025 19:00
@JonEckenrode JonEckenrode merged commit 80d6013 into main Mar 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants