Add PreloadManager snippets, and update media3 to 1.8.0 #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
|
Here is the summary of changes. You are about to add 7 region tags.
This comment is generated by snippet-bot.
|
Adding snippets to support new PreloadManager docs. That requires bumping the Media3 version up to 1.8.0.
gradle/libs.versions.toml
Outdated
| @@ -187,6 +189,8 @@ play-services-wearable = { module = "com.google.android.gms:play-services-wearab | |||
| validator-push = { module = "com.google.android.wearable.watchface.validator:validator-push", version.ref = "validatorPush" } | |||
| wear-compose-material = { module = "androidx.wear.compose:compose-material", version.ref = "wearComposeMaterial" } | |||
| wear-compose-material3 = { module = "androidx.wear.compose:compose-material3", version.ref = "wearComposeMaterial3" } | |||
| androidx-media3-common-ktx = { group = "androidx.media3", name = "media3-common-ktx", version.ref = "media3CommonKtx" } | |||
| media3-exoplayer = { group = "androidx.media3", name = "media3-exoplayer", version.ref = "media3Exoplayer" } | |||
There was a problem hiding this comment.
Can we keep naming convention as same ? Eg change to "androidx-media3-exoplayer"
There was a problem hiding this comment.
Thanks for spotting that! I'd just accepted Android Studio's proposed fix, but in fact, we already include Media3 common & exoplayer at lines 136-7 -- I just needed to update the version number (to 1.8.0) and add those labels to the dependencies. PTAL!
tianyif
reviewed
Aug 11, 2025
| // [START android_defaultpreloadmanager_getAndPlayMedia] | ||
| // When a media item is about to display on the screen | ||
| val mediaSource = preloadManager.getMediaSource(mediaItem) | ||
| if (mediaSource != null) { |
There was a problem hiding this comment.
Shall we change the L101-103 to
if (mediaSource != null) {
player.setMediaSource(mediaSource)
} else {
// If the mediaItem hasn't been added to the preload manager yet,
// set it directly to the player when it's about to play
player.setMediaItem(mediaItem)
}
There was a problem hiding this comment.
Thanks! Yes, that was a quick cleanup just to get it to compile -- this version makes it a better example.
I changed the comment slightly, PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting doc snippets used for the new PreloadManager documentation. Had to bump the Media3 version up to 1.8.0 for some of the new APIs in that doc.
Once we've submitted this in Github, I'll update my docs to pull the code snippets in from there.