-
Notifications
You must be signed in to change notification settings - Fork 247
Add PreloadManager snippets, and update media3 to 1.8.0 #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asolovay
wants to merge
13
commits into
main
Choose a base branch
from
myPlmSnippetsBranch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7db6576
Adding PreloadManager doc snippets
asolovay c413e5d
Adding PreloadManager doc snippets
asolovay 64a7c2e
Adding PreloadManager doc snippets
asolovay 645200f
Adding PreloadManager doc snippets
asolovay 9d2a9a7
Merge remote-tracking branch 'origin/myPlmSnippetsBranch' into myPlmS…
asolovay da757c4
Adding PreloadManager doc snippets
asolovay 9c60408
Adding PreloadManager doc snippets
asolovay 6d26bda
Adding PreloadManager doc snippets
asolovay b954cca
Merge branch 'main' into myPlmSnippetsBranch
asolovay 07439af
Apply Spotless
asolovay 306b0d2
Adding PreloadManager doc snippets
asolovay 9b61f77
Merge branch 'main' into myPlmSnippetsBranch
asolovay 46e8722
Merge branch 'main' into myPlmSnippetsBranch
asolovay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 134 additions & 0 deletions
134
misc/src/main/java/com/example/snippets/PreloadManagerKotlinSnippets.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
/* | ||
* Copyright 2025 The Android Open Source Project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.example.snippets | ||
|
||
import android.os.Bundle | ||
import androidx.annotation.OptIn | ||
import androidx.appcompat.app.AppCompatActivity | ||
import androidx.media3.common.C | ||
import androidx.media3.common.MediaItem | ||
import androidx.media3.common.util.UnstableApi | ||
import androidx.media3.exoplayer.ExoPlayer | ||
import androidx.media3.exoplayer.source.preload.DefaultPreloadManager | ||
import androidx.media3.exoplayer.source.preload.TargetPreloadStatusControl | ||
import java.lang.Math.abs | ||
|
||
// constants to make the code snippets work | ||
const val currentPlayingIndex = 10 | ||
|
||
@UnstableApi | ||
// [START android_defaultpreloadmanager_MyTargetPreloadStatusControl] | ||
class MyTargetPreloadStatusControl( | ||
currentPlayingIndex: Int = C.INDEX_UNSET | ||
) : TargetPreloadStatusControl<Int, DefaultPreloadManager.PreloadStatus> { | ||
|
||
override fun getTargetPreloadStatus(index: Int): DefaultPreloadManager.PreloadStatus? { | ||
if (index - currentPlayingIndex == 1) { // next track | ||
// return a PreloadStatus that is labelled by STAGE_SPECIFIED_RANGE_LOADED and | ||
// suggest loading 3000ms from the default start position | ||
return DefaultPreloadManager.PreloadStatus.specifiedRangeLoaded(3000L) | ||
} else if (index - currentPlayingIndex == -1) { // previous track | ||
// return a PreloadStatus that is labelled by STAGE_SPECIFIED_RANGE_LOADED and | ||
// suggest loading 3000ms from the default start position | ||
return DefaultPreloadManager.PreloadStatus.specifiedRangeLoaded(3000L) | ||
} else if (abs(index - currentPlayingIndex) == 2) { | ||
// return a PreloadStatus that is labelled by STAGE_TRACKS_SELECTED | ||
return DefaultPreloadManager.PreloadStatus.TRACKS_SELECTED | ||
} else if (abs(index - currentPlayingIndex) <= 4) { | ||
// return a PreloadStatus that is labelled by STAGE_SOURCE_PREPARED | ||
return DefaultPreloadManager.PreloadStatus.SOURCE_PREPARED | ||
} | ||
return null | ||
} | ||
} | ||
// [END android_defaultpreloadmanager_MyTargetPreloadStatusControl] | ||
|
||
class PreloadManagerSnippetsKotlin { | ||
|
||
class PreloadSnippetsActivity : AppCompatActivity() { | ||
private val context = this | ||
|
||
@OptIn(UnstableApi::class) | ||
override fun onCreate(savedInstanceState: Bundle?) { | ||
super.onCreate(savedInstanceState) | ||
|
||
// [START android_defaultpreloadmanager_createPLM] | ||
val targetPreloadStatusControl = MyTargetPreloadStatusControl() | ||
val preloadManagerBuilder = | ||
DefaultPreloadManager.Builder(context, targetPreloadStatusControl) | ||
val preloadManager = preloadManagerBuilder.build() | ||
// [END android_defaultpreloadmanager_createPLM] | ||
|
||
val player = preloadManagerBuilder.buildExoPlayer() | ||
|
||
// [START android_defaultpreloadmanager_addMedia] | ||
val initialMediaItems = pullMediaItemsFromService(/* count= */ 20) | ||
for (index in 0 until initialMediaItems.size) { | ||
preloadManager.add(initialMediaItems.get(index), /* rankingData= */ index) | ||
} | ||
// items aren't actually loaded yet! need to call invalidate() after this | ||
// [END android_defaultpreloadmanager_addMedia] | ||
|
||
// [START android_defaultpreloadmanager_invalidate] | ||
preloadManager.invalidate() | ||
// [END android_defaultpreloadmanager_invalidate] | ||
} | ||
|
||
@OptIn(UnstableApi::class) | ||
private fun fetchMedia( | ||
preloadManager: DefaultPreloadManager, | ||
mediaItem: MediaItem, | ||
player: ExoPlayer, | ||
currentIndex: Int | ||
) { | ||
// [START android_defaultpreloadmanager_getAndPlayMedia] | ||
// When a media item is about to display on the screen | ||
val mediaSource = preloadManager.getMediaSource(mediaItem) | ||
if (mediaSource != null) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shall we change the L101-103 to
|
||
player.setMediaSource(mediaSource) | ||
} | ||
player.prepare() | ||
|
||
// When the media item is displaying at the center of the screen | ||
player.play() | ||
preloadManager.setCurrentPlayingIndex(currentIndex) | ||
|
||
// Need to call invalidate() to update the priorities | ||
preloadManager.invalidate() | ||
// [END android_defaultpreloadmanager_getAndPlayMedia] | ||
} | ||
|
||
@OptIn(UnstableApi::class) | ||
private fun removeMedia(mediaItem: MediaItem, preloadManager: DefaultPreloadManager) { | ||
// [START android_defaultpreloadmanager_removeItem] | ||
preloadManager.remove(mediaItem) | ||
// [END android_defaultpreloadmanager_removeItem] | ||
} | ||
|
||
@OptIn(UnstableApi::class) | ||
private fun releasePLM(preloadManager: DefaultPreloadManager) { | ||
// [START android_defaultpreloadmanager_releasePLM] | ||
preloadManager.release() | ||
// [END android_defaultpreloadmanager_releasePLM] | ||
} | ||
|
||
// dummy methods to support the code snippets | ||
private fun pullMediaItemsFromService(count: Int): List<MediaItem> { | ||
return listOf() | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep naming convention as same ? Eg change to "androidx-media3-exoplayer"