Skip to content

Fixing compile error in DeviceCompatibilityModeTestJavaSnippets #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Fixing compile error in DeviceCompatibilityModeTestJavaSnippets #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions misc/src/androidTest/java/com/example/snippets/DeviceCompatibilityModeTestJavaSnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.example.snippets;

import androidx.appcompat.app.AppCompatActivity
import androidx.test.core.app.ActivityScenario;
import androidx.test.ext.junit.rules.ActivityScenarioRule;
import org.junit.Rule;
Expand All @@ -42,7 +41,7 @@ public void activity_launched_notLetterBoxed() {


// Method used by snippets.
public boolean isLetterboxed(AppCompatActivity activity) {
public boolean isLetterboxed(MainActivity activity) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you move to MainActivity instead of AppCompatActivity?
If the problem was a ; missing, this shouldn't be needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above -- when I added the semicolon I still couldn't compile, because isLetterBoxed() 's return value was being passed to something that expected a MainActivity. I don't know if this was the best way to fix that but it works and it doesn't change the code that's actually included in the docs, so 🤷

Thanks for submitting!

return true;
}

Expand Down