Skip to content

Disabling some "unused" warnings #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 3, 2025
Merged

Disabling some "unused" warnings #610

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6333f90
Disabling some "unused" warnings
asolovay Aug 29, 2025
09cf3eb
Disabling some "unused" warnings
asolovay Aug 29, 2025
40c4d70
Disabling some "unused" warnings
asolovay Sep 2, 2025
fd2470b
Merge remote-tracking branch 'origin/unused-code-cleanup' into unused…
asolovay Sep 2, 2025
f33efaa
Merge branch 'main' into unused-code-cleanup
asolovay Sep 2, 2025
7ce9be0
Merge branch 'main' into unused-code-cleanup
asolovay Sep 2, 2025
2547dff
Merge branch 'main' into unused-code-cleanup
asolovay Sep 3, 2025
e6e7700
Changing "UNUSED" to lower-case
asolovay Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions misc/src/main/java/com/example/snippets/PreloadManagerKotlinSnippets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import java.lang.Math.abs
// constants to make the code snippets work
const val currentPlayingIndex = 10

@Suppress("Unused")
@UnstableApi
// [START android_defaultpreloadmanager_MyTargetPreloadStatusControl]
class MyTargetPreloadStatusControl(
Expand Down Expand Up @@ -57,6 +58,7 @@ class MyTargetPreloadStatusControl(
}
// [END android_defaultpreloadmanager_MyTargetPreloadStatusControl]

@Suppress("Unused")
class PreloadManagerSnippetsKotlin {

class PreloadSnippetsActivity : AppCompatActivity() {
Expand All @@ -73,8 +75,6 @@ class PreloadManagerSnippetsKotlin {
val preloadManager = preloadManagerBuilder.build()
// [END android_defaultpreloadmanager_createPLM]

val player = preloadManagerBuilder.buildExoPlayer()

// [START android_defaultpreloadmanager_addMedia]
val initialMediaItems = pullMediaItemsFromService(/* count= */ 20)
for (index in 0 until initialMediaItems.size) {
Expand Down
2 changes: 2 additions & 0 deletions misc/src/main/java/com/example/snippets/backgroundwork/WakeLockSnippetsJava.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import androidx.annotation.Nullable;

@SuppressWarnings("Unused")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java all caps:
@SuppressWarnings("UNUSED")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just wanted to confirm here that it's @SuppressWarnings() in Java, but @Suppress() in Kotlin?

Copy link
Contributor Author

@asolovay asolovay Sep 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually -- when I amend my commit, I still get the warning "Method 'doSomethingAndRelease()' is never used" for this Java file (but not for the Kotlin file).

Is there something I'm doing wrong with @SuppressWarnings()? Right now I have:

    @SuppressWarnings("UNUSED")
    // [START android_backgroundwork_wakelock_release_java]
    void doSomethingAndRelease() throws MyException {
        try {
            wakeLock.acquire();
            doTheWork();
        } finally {
            wakeLock.release();
        }
    }
    // [END android_backgroundwork_wakelock_release_java]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable to me. Can you clarify where you are seeing the morning? Is this in Android Studio or a when you run a command line lint command? I can try your steps to reproduce.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in Android Studio, when I try to push the commit to GitHub--it pops up a screen saying "there are these warnings, are you sure you want to push?"

But when I try compiling the "misc" module, I get no warnings. So if the answer is "pay attention to that, don't worry about the warning you get when you push", I'm happy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to use @SuppressWarnings("unused") in Java. Android Studio lint only respects this if the "unused" is lowercase.

I'm thinking we should use lower case for both Kotlin: @Suppress("unused") and Java @SuppressWarnings("unused"). The capitalized version only work in Kotlin, so I would prefer to be consistent across languages by using lowercase.

public class WakeLockSnippetsJava extends Activity {

PowerManager.WakeLock wakeLock;
Expand All @@ -23,6 +24,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
}

@SuppressWarnings("Unused")
// [START android_backgroundwork_wakelock_release_java]
void doSomethingAndRelease() throws MyException {
try {
Expand Down
1 change: 1 addition & 0 deletions misc/src/main/java/com/example/snippets/backgroundwork/WakeLockSnippetsKotlin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import android.os.Bundle
import android.os.PowerManager

// Snippets for doc page go here
@Suppress("Unused")
class WakeLockSnippetsKotlin : Activity() {

// [START android_backgroundwork_wakelock_create_kotlin]
Expand Down