Conversation
…pensearch-project#20814) `_field_caps` returns an empty response for indexes where a `disable_objects: true` object field has been populated with a child field. A second bug causes such child fields to be corrupted after any subsequent document is indexed into the same index - for example `attributes.foo.bar` becomes `attributes.foo.foo.bar`. ## Root causes When `_field_caps` walks the parent chain of a flattened leaf field (e.g. `attributes.foo.bar`), it looks up an `ObjectMapper` for each intermediate path. Under `disable_objects: true`, intermediate paths like `attributes.foo` have no `ObjectMapper` by design - the fix adds a null check to skip them and continue up the chain. The field name corruption is caused by `ParametrizedFieldMapper.merge()` using `name().lastIndexOf('.')` to reconstruct the parent `ContentPath` when rebuilding a mapper. For a field with `simpleName` `foo.bar` and full name `attributes.foo.bar`, this returns the position of the dot before `bar` rather than the dot before `foo.bar`, so the parent path is computed as `attributes.foo` instead of `attributes`. The fix computes the boundary from `simpleName.length()` instead. Signed-off-by: Cyrus Saeid <cyrus.s.dev@gmail.com> Co-authored-by: Cyrus Saeid <cyrus.s.dev@gmail.com>
…oject#20951) Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release notes for OpenSearch 3.6.0, covering commits from 3.5.0 to HEAD of main (trial run).
Borderline calls
bug, adds range validations. Could also be Added.bugbut reads as a performance optimization. Could also be Fixed.skip-diff-analyzerlabel but noskip-changelog.skip-changelog) — TransferManager race condition fix. Could be Fixed if considered user-facing.Check List
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.