Skip to content

fix numbers as event names #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix numbers as event names #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ export type EventMap = {
[key: string]: (...args: any[]) => void
}

type KeyOf<T> = keyof T | `${Extract<keyof T,number>}` | (Extract<keyof T,`${number}`> extends never ? never : number);

/**
* Type-safe event emitter.
*
Expand All @@ -19,22 +21,22 @@ export type EventMap = {
* ```
*/
interface TypedEventEmitter<Events extends EventMap> {
addListener<E extends keyof Events> (event: E, listener: Events[E]): this
on<E extends keyof Events> (event: E, listener: Events[E]): this
once<E extends keyof Events> (event: E, listener: Events[E]): this
prependListener<E extends keyof Events> (event: E, listener: Events[E]): this
prependOnceListener<E extends keyof Events> (event: E, listener: Events[E]): this
addListener<E extends KeyOf<Events>> (event: E, listener: Events[E]): this
on<E extends KeyOf<Events>> (event: E, listener: Events[E]): this
once<E extends KeyOf<Events>> (event: E, listener: Events[E]): this
prependListener<E extends KeyOf<Events>> (event: E, listener: Events[E]): this
prependOnceListener<E extends KeyOf<Events>> (event: E, listener: Events[E]): this

off<E extends keyof Events>(event: E, listener: Events[E]): this
removeAllListeners<E extends keyof Events> (event?: E): this
removeListener<E extends keyof Events> (event: E, listener: Events[E]): this
off<E extends KeyOf<Events>>(event: E, listener: Events[E]): this
removeAllListeners<E extends KeyOf<Events>> (event?: E): this
removeListener<E extends KeyOf<Events>> (event: E, listener: Events[E]): this

emit<E extends keyof Events> (event: E, ...args: Parameters<Events[E]>): boolean
emit<E extends KeyOf<Events>> (event: E, ...args: Parameters<Events[E]>): boolean
// The sloppy `eventNames()` return type is to mitigate type incompatibilities - see #5
eventNames (): (keyof Events | string | symbol)[]
rawListeners<E extends keyof Events> (event: E): Events[E][]
listeners<E extends keyof Events> (event: E): Events[E][]
listenerCount<E extends keyof Events> (event: E): number
eventNames (): (KeyOf<Events> | string | symbol)[]
rawListeners<E extends KeyOf<Events>> (event: E): Events[E][]
listeners<E extends KeyOf<Events>> (event: E): Events[E][]
listenerCount<E extends KeyOf<Events>> (event: E): number

getMaxListeners (): number
setMaxListeners (maxListeners: number): this
Expand Down