-
Notifications
You must be signed in to change notification settings - Fork 57
Feature/switch to frame #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new Selenium tool named "switch_to_frame" was introduced in the server logic, allowing frame context switching by locator, index, or resetting to default content. The tool handles errors and prioritizes switching methods based on provided parameters. No other functional changes were made, aside from a minor newline addition. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant Selenium
Client->>Server: Call switch_to_frame(by?, value?, index?, defaultContent?)
alt defaultContent is true
Server->>Selenium: Switch to default content
else index is provided
Server->>Selenium: Switch to frame by index
else by and value are provided
Server->>Selenium: Switch to frame by locator
else
Server-->>Client: Return "No valid frame selector provided"
end
Server-->>Client: Return success or error message
Estimated code review effort2 (~15 minutes) Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request introduces the capability to switch to iframes within the Selenium MCP server.
It enhances the server’s functionality by enabling iframe handling, which is essential for interacting with web elements embedded in nested contexts.
Summary by CodeRabbit