Skip to content

Feature/switch to frame #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VishalBose7
Copy link

@VishalBose7 VishalBose7 commented Jul 22, 2025

This pull request introduces the capability to switch to iframes within the Selenium MCP server.
It enhances the server’s functionality by enabling iframe handling, which is essential for interacting with web elements embedded in nested contexts.

Summary by CodeRabbit

  • New Features
    • Introduced a tool that allows switching the browser context to a specific frame or back to the main document during automated browser sessions. Users can switch by frame locator, index, or return to the default content.

Copy link

coderabbitai bot commented Jul 22, 2025

Walkthrough

A new Selenium tool named "switch_to_frame" was introduced in the server logic, allowing frame context switching by locator, index, or resetting to default content. The tool handles errors and prioritizes switching methods based on provided parameters. No other functional changes were made, aside from a minor newline addition.

Changes

File(s) Change Summary
src/lib/server.js Added "switch_to_frame" tool for Selenium context switching by locator, index, or default content; minor newline added.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    participant Selenium

    Client->>Server: Call switch_to_frame(by?, value?, index?, defaultContent?)
    alt defaultContent is true
        Server->>Selenium: Switch to default content
    else index is provided
        Server->>Selenium: Switch to frame by index
    else by and value are provided
        Server->>Selenium: Switch to frame by locator
    else
        Server-->>Client: Return "No valid frame selector provided"
    end
    Server-->>Client: Return success or error message
Loading

Estimated code review effort

2 (~15 minutes)

Poem

A frame here, a frame there,
Now I can hop anywhere!
By index or by name,
I’ll never lose my frame.
With every switch, I leap anew—
Selenium’s world, now easier to view!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c1d066 and 7975a44.

📒 Files selected for processing (1)
  • src/lib/server.js (2 hunks)
🔇 Additional comments (2)
src/lib/server.js (2)

176-209: Well-implemented iframe switching functionality.

The implementation follows excellent practices:

  • Clear parameter design with appropriate optional constraints
  • Logical prioritization of switching methods (defaultContent > index > locator)
  • Proper error handling with meaningful messages
  • Consistent integration with existing helper functions (getDriver(), getLocator())
  • Correct usage of Selenium's switchTo() API

The tool properly handles all three common iframe switching scenarios and provides clear feedback for invalid parameter combinations.


514-514: Good formatting improvement.

Adding the trailing newline improves code consistency and follows standard formatting practices.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant