Skip to content

feat(nf): prevents bundle adapter hiding errors when building artifacts #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import path from 'path';
import fs from 'fs';
import path from 'path';

import { NormalizedFederationConfig } from '../config/federation-config';
import { FederationOptions } from './federation-options';
import { bundle } from '../utils/build-utils';
import { ExposesInfo, SharedInfo } from '@softarc/native-federation-runtime';
import { NormalizedFederationConfig } from '../config/federation-config';
import {
createBuildResultMap,
lookupInResultMap,
} from '../utils/build-result-map';
import { bundle } from '../utils/build-utils';
import { logger } from '../utils/logger';
import { normalize } from '../utils/normalize';
import { FederationOptions } from './federation-options';

export interface ArtefactInfo {
mappings: SharedInfo[];
Expand Down Expand Up @@ -40,18 +40,24 @@ export async function bundleExposedAndMappings(

logger.info('Building federation artefacts');

const result = await bundle({
entryPoints,
outdir: fedOptions.outputPath,
tsConfigPath: fedOptions.tsConfig,
external: externals,
dev: !!fedOptions.dev,
watch: fedOptions.watch,
mappedPaths: config.sharedMappings,
kind: 'mapping-or-exposed',
hash,
optimizedMappings: config.features.ignoreUnusedDeps,
});
let result;
try {
result = await bundle({
entryPoints,
outdir: fedOptions.outputPath,
tsConfigPath: fedOptions.tsConfig,
external: externals,
dev: !!fedOptions.dev,
watch: fedOptions.watch,
mappedPaths: config.sharedMappings,
kind: 'mapping-or-exposed',
hash,
optimizedMappings: config.features.ignoreUnusedDeps,
});
} catch (error) {
logger.error('Error building federation artefacts');
throw error;
}

const resultMap = createBuildResultMap(result, hash);

Expand All @@ -70,8 +76,8 @@ export async function bundleExposedAndMappings(
dev: !fedOptions.dev
? undefined
: {
entryPoint: normalize(path.normalize(item.fileName)),
},
entryPoint: normalize(path.normalize(item.fileName)),
},
});
}

Expand All @@ -84,10 +90,10 @@ export async function bundleExposedAndMappings(
dev: !fedOptions.dev
? undefined
: {
entryPoint: normalize(
path.join(fedOptions.workspaceRoot, item.fileName)
),
},
entryPoint: normalize(
path.join(fedOptions.workspaceRoot, item.fileName)
),
},
});
}

Expand All @@ -111,8 +117,8 @@ export function describeExposed(
dev: !options.dev
? undefined
: {
entryPoint: localPath,
},
entryPoint: localPath,
},
});
}

Expand All @@ -136,8 +142,8 @@ export function describeSharedMappings(
dev: !fedOptions.dev
? undefined
: {
entryPoint: normalize(path.normalize(m.path)),
},
entryPoint: normalize(path.normalize(m.path)),
},
});
}

Expand Down
Loading