Skip to content

Rename constant #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename constant #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/mf/rspack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export * from './src/rspack';
export {
DEFAULT_SECONARIES_SKIP_LIST,
DEFAULT_SECONDARY_SKIP_LIST,
DEFAULT_SKIP_LIST,
SharedMappings,
findRootTsConfigJson,
Expand Down
8 changes: 4 additions & 4 deletions libs/mf/src/utils/share-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const DEFAULT_SKIP_LIST = [
'zone.js',
];

export const DEFAULT_SECONARIES_SKIP_LIST = [
export const DEFAULT_SECONDARY_SKIP_LIST = [
'@angular/router/upgrade',
'@angular/common/upgrade',
];
Expand Down Expand Up @@ -135,7 +135,7 @@ function getSecondaries(
packagePath: string,
key: string,
shareObject: SharedConfig,
exclude = [...DEFAULT_SECONARIES_SKIP_LIST]
exclude = [...DEFAULT_SECONDARY_SKIP_LIST]
): Record<string, SharedConfig> {
if (typeof includeSecondaries === 'object') {
if (Array.isArray(includeSecondaries.skip)) {
Expand Down Expand Up @@ -217,7 +217,7 @@ function readConfiguredSecondaries(

export function shareAll(
config: CustomSharedConfig = {},
skip: string[] = [...DEFAULT_SKIP_LIST, ...DEFAULT_SECONARIES_SKIP_LIST],
skip: string[] = [...DEFAULT_SKIP_LIST, ...DEFAULT_SECONDARY_SKIP_LIST],
packageJsonPath = ''
): Config {
if (!packageJsonPath) {
Expand Down Expand Up @@ -247,7 +247,7 @@ export function setInferVersion(infer: boolean): void {
export function share(
shareObjects: Config,
packageJsonPath = '',
skip: string[] = DEFAULT_SECONARIES_SKIP_LIST
skip: string[] = DEFAULT_SECONDARY_SKIP_LIST
): Config {
if (!packageJsonPath) {
packageJsonPath = cwd();
Expand Down
4 changes: 2 additions & 2 deletions libs/mf/src/utils/with-mf-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {
DEFAULT_SECONARIES_SKIP_LIST,
DEFAULT_SECONDARY_SKIP_LIST,
DEFAULT_SKIP_LIST,
findRootTsConfigJson,
shareAll,
Expand All @@ -15,7 +15,7 @@ export function withModuleFederationPlugin(config: unknown) {

const skip = [
...DEFAULT_SKIP_LIST,
...DEFAULT_SECONARIES_SKIP_LIST,
...DEFAULT_SECONDARY_SKIP_LIST,
...(config['skip'] || []),
];

Expand Down
4 changes: 2 additions & 2 deletions libs/native-federation-core/src/lib/config/share-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {

let inferVersion = false;

export const DEFAULT_SECONARIES_SKIP_LIST = [
export const DEFAULT_SECONDARY_SKIP_LIST = [
'@angular/router/upgrade',
'@angular/common/upgrade',
];
Expand Down Expand Up @@ -156,7 +156,7 @@ function getSecondaries(
key: string,
shareObject: SharedConfig
): Record<string, SharedConfig> | null {
let exclude = [...DEFAULT_SECONARIES_SKIP_LIST];
let exclude = [...DEFAULT_SECONDARY_SKIP_LIST];

if (typeof includeSecondaries === 'object') {
if (Array.isArray(includeSecondaries.skip)) {
Expand Down