Skip to content

feature: update ngrx version to 13.0.1 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feature: update ngrx version to 13.0.1 #90

wants to merge 1 commit into from

Conversation

mehrad-rafigh
Copy link

When running schematics and adding the ngrx flag, the following error occurs

npx ng g @angular-architects/ddd:feature damage-assessment --domain olb --entity damage --ngrx --type publishable --app example --importPath @ewp/olb/damage-assessment                    
⠸ Installing packages (npm)...npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/core
npm ERR!   @angular/core@"^13.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/core@"^10.0.0" from @ngrx/[email protected]
npm ERR! node_modules/@ngrx/effects
npm ERR!   @ngrx/effects@"10.1.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/mehrad/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/mehrad/.npm/_logs/2021-11-30T13_52_12_144Z-debug.log
✖ Package install failed, see above.
UnsuccessfulWorkflowExecution [Error]: Workflow did not execute successfully.
    at ChildProcess.<anonymous> (/home/mehrad/dev/work/enterprise-web-platform/node_modules/@angular-devkit/schematics/tasks/package-manager/executor.js:134:31)
    at ChildProcess.emit (events.js:400:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
The generator workflow failed. See above.

@mehrad-rafigh
Copy link
Author

@manfredsteyer @benpsnyder @peterbsmyth can we get this reviewed and merged please? Its blocking my team and we really like to use this plugin.
Cheers

@benpsnyder
Copy link

@mehrad-rafigh first we should merge Upgrade to Yarn v3, Nx 13.1.4, and move to @nrwl/nx-plugin proper structure #91

@benpsnyder
Copy link

@manfredsteyer @benpsnyder @peterbsmyth can we get this reviewed and merged please? Its blocking my team and we really like to use this plugin. Cheers

In the meantime, you can have your team do the following:

  • <ProjectsDir>/<yourProject>
  • <ProjectsDir>/nx-ddd-plugin

Have them switch branches on <ProjectsDir>/nx-ddd-plugin to include your changes

  • run yarn build

On <ProjectsDir>/<yourProject>/package.json update the @angular-architects/ddd dependency to be:

"@angular-architects/ddd": "file:../nx-ddd-plugin/dist/libs/ddd", 

Then when you run yarn install from <ProjectsDir>/<yourProject>/ it will use the locally built version of @angular-architects/ddd which has your customizations. You don't need to wait for @manfredsteyer to publish to NPM

@mehrad-rafigh
Copy link
Author

@benpsnyder Thank you for the guide. Much appreciated :)

@mehrad-rafigh mehrad-rafigh deleted the feature/update-ngrx-to-v13 branch January 20, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants