This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix issue #2110 #2129
Open
Fix issue #2110 #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caret for drop-down now marked aria-hidden. See angular-ui#2110
Revert "Dist version of previous commit." This reverts commit 2aa868f.
|
For issue 2110: #2110 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to satisfy WCAG compliance checkers. The drop-down caret is now marked aria-hidden.
As long as the input-id attribute on the ui-select tag is used along with a matching <label for="..." then I would think screen readers should be able to make sense of it.