fix(@angular-devkit/core): fix 'this' check (#12873)

vikerman · web-flow · commit df4ee8c49159 · 2018-11-06T20:44:06.000-08:00
diff --git a/packages/angular_devkit/core/src/json/schema/registry.ts b/packages/angular_devkit/core/src/json/schema/registry.ts
@@ -588,7 +588,9 @@ export class CoreSchemaRegistry implements SchemaRegistry {
         compilationSchemInfo.promptDefinitions.push(definition);
 
         return function(this: { promptFieldsWithValue: Set<string> }) {
-          if (this) {
+          // If 'this' is undefined in the call, then it defaults to the global
+          // 'this'.
+          if (this && this.promptFieldsWithValue) {
             this.promptFieldsWithValue.add(path);
           }
 

Original file line number	Diff line number	Diff line change
`@@ -588,7 +588,9 @@ export class CoreSchemaRegistry implements SchemaRegistry {`
`588`	`588`	`compilationSchemInfo.promptDefinitions.push(definition);`
`589`	`589`
`590`	`590`	`return function(this: { promptFieldsWithValue: Set<string> }) {`
`591`		`- if (this) {`
	`591`	`+ // If 'this' is undefined in the call, then it defaults to the global`
	`592`	`+ // 'this'.`
	`593`	`+ if (this && this.promptFieldsWithValue) {`
`592`	`594`	`this.promptFieldsWithValue.add(path);`
`593`	`595`	`}`
`594`	`596`