Skip to content

refactor(@schematics/angular): move @angular/ssr dependency to server schematic #28284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024
Merged

refactor(@schematics/angular): move @angular/ssr dependency to server schematic #28284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/schematics/angular/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ function addDependencies(skipInstall: boolean | undefined): Rule {
const install = skipInstall ? InstallBehavior.None : InstallBehavior.Auto;

return chain([
addDependency('@angular/ssr', latestVersions.AngularSSR, {
type: DependencyType.Default,
install,
}),
addDependency('@angular/platform-server', coreDep.version, {
type: DependencyType.Default,
install,
Expand All @@ -154,7 +158,7 @@ function addDependencies(skipInstall: boolean | undefined): Rule {
}

export default function (options: ServerOptions): Rule {
return async (host: Tree, context: SchematicContext) => {
return async (host: Tree) => {
const workspace = await getWorkspace(host);
const clientProject = workspace.projects.get(options.project);
if (clientProject?.extensions.projectType !== 'application') {
Expand Down
4 changes: 0 additions & 4 deletions packages/schematics/angular/ssr/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,6 @@ function addDependencies({ skipInstall }: SSROptions, isUsingApplicationBuilder:
const install = skipInstall ? InstallBehavior.None : InstallBehavior.Auto;

const rules: Rule[] = [
addDependency('@angular/ssr', latestVersions.AngularSSR, {
type: DependencyType.Default,
install,
}),
addDependency('express', latestVersions['express'], {
type: DependencyType.Default,
install,
Expand Down