Skip to content

Conversation

crisbeto
Copy link
Member

Updates the repo to the TypeScript 5.6 RC and narrows down the version to drop support for 5.4, in line with the compiler.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 29, 2024
@crisbeto crisbeto force-pushed the ts-5.6-rc branch 5 times, most recently from ef3900a to 59248b4 Compare August 29, 2024 07:20
return this._actions.length;
}
[Symbol.iterator]() {
[Symbol.iterator](): IterableIterator<Action> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needed an explicit return type or the API extractor would crash.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Aug 29, 2024
@crisbeto crisbeto marked this pull request as ready for review August 29, 2024 07:34
@crisbeto crisbeto requested a review from alan-agius4 August 29, 2024 07:38
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, otherwise looks good.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 29, 2024
Updates the repo to the TypeScript 5.6 RC and narrows down the version to drop support for 5.4, in line with the compiler.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 29, 2024
@crisbeto
Copy link
Member Author

Feedback has been addressed.

@alan-agius4 alan-agius4 merged commit 7f570c5 into angular:main Aug 29, 2024
29 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants