Skip to content

test: update ssr UT to zoneless #28328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
+7 −9
Merged

test: update ssr UT to zoneless #28328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/angular/ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"@angular/platform-browser": "19.0.0-next.2",
"@angular/platform-server": "19.0.0-next.2",
"@angular/router": "19.0.0-next.2",
"@bazel/runfiles": "^5.8.1",
"zone.js": "^0.15.0"
"@bazel/runfiles": "^5.8.1"
},
"schematics": "./schematics/collection.json",
"repository": {
Expand Down
1 change: 0 additions & 1 deletion packages/angular/ssr/test/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ ts_library(
"@npm//@angular/platform-browser",
"@npm//@angular/platform-server",
"@npm//@angular/router",
"@npm//zone.js",
],
)

Expand Down
1 change: 0 additions & 1 deletion packages/angular/ssr/test/app-engine_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

/* eslint-disable import/no-unassigned-import */
import 'zone.js/node';
import '@angular/compiler';
/* eslint-enable import/no-unassigned-import */

Expand Down
1 change: 0 additions & 1 deletion packages/angular/ssr/test/app_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

/* eslint-disable import/no-unassigned-import */
import 'zone.js/node';
import '@angular/compiler';
/* eslint-enable import/no-unassigned-import */

Expand Down
1 change: 0 additions & 1 deletion packages/angular/ssr/test/assets_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

import { ServerAssets } from '../src/assets';
import { AngularAppManifest } from '../src/manifest';

describe('ServerAsset', () => {
let assetManager: ServerAssets;
Expand Down
8 changes: 6 additions & 2 deletions packages/angular/ssr/test/testing-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.dev/license
*/

import { Component } from '@angular/core';
import { Component, provideExperimentalZonelessChangeDetection } from '@angular/core';
import { bootstrapApplication } from '@angular/platform-browser';
import { provideServerRendering } from '@angular/platform-server';
import { RouterOutlet, Routes, provideRouter } from '@angular/router';
Expand Down Expand Up @@ -48,7 +48,11 @@ export function setAngularAppTestingManifest(routes: Routes, baseHref = ''): voi
class AppComponent {}

return bootstrapApplication(AppComponent, {
providers: [provideServerRendering(), provideRouter(routes)],
providers: [
provideServerRendering(),
provideExperimentalZonelessChangeDetection(),
provideRouter(routes),
],
});
},
});
Expand Down
1 change: 0 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,6 @@ __metadata:
"@angular/router": "npm:19.0.0-next.2"
"@bazel/runfiles": "npm:^5.8.1"
tslib: "npm:^2.3.0"
zone.js: "npm:^0.15.0"
peerDependencies:
"@angular/common": ^19.0.0-next.0
"@angular/core": ^19.0.0-next.0
Expand Down