fix(@angular/ssr): resolve circular dependency issue from main.server.js reference in manifest #28359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
circular-deps
branch
2 times, most recently
from
b710743 to
893a1a7
Compare
alan-agius4
force-pushed
the
circular-deps
branch
from
893a1a7 to
7d9ce24
Compare
….js reference in manifest The issue was addressed by changing the top-level import to a dynamic import. Closes angular#28358
alan-agius4
force-pushed
the
circular-deps
branch
from
5877a20 to
816e8be
Compare
alan-agius4
added
target: major
clydin
approved these changes
Sep 6, 2024
alan-agius4
added
action: merge
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was addressed by changing the top-level import to a dynamic import.
Closes #28358