Skip to content

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Sep 9, 2024

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Running ng e2e without a configured e2e target recommends several runners, but not Playwright.

Issue Number: N/A

What is the new behavior?

Playwright is in the list of recommended e2e frameworks.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I was a little unsure on what's right position in the list. I put it at the top because I obviously think Playwright is the greatest, but I guess I'm partial :D Let me know if a different position works better, happy to move it.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: @angular/cli labels Sep 9, 2024
@alan-agius4
Copy link
Collaborator

@Skn0tt, thanks for this, the order doesn’t matter as such as these will be sorted alphabetically.

Can you change the commit message type to docs so that we can include this in the next patch? Otherwise this change will be released as part of v19.

@Skn0tt Skn0tt force-pushed the e2e-add-playwright branch from 471ebba to 27acff5 Compare September 9, 2024 11:57
@angular-robot angular-robot bot added area: docs Related to the documentation and removed detected: feature PR contains a feature commit labels Sep 9, 2024
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Sep 9, 2024

Thanks for the quick review! Updated the commit message and PR title.

@Skn0tt Skn0tt changed the title feat(@angular/cli): add Playwright to e2e targets docs(@angular/cli): add Playwright to e2e targets Sep 9, 2024
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Sep 9, 2024
@alan-agius4 alan-agius4 merged commit e4d598f into angular:main Sep 9, 2024
33 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 18.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants