Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 10, 2024

I often struggle with spacing around block comments, so I've decided to add the lines-around-comment lint rule to help manage this.

For more details, see the https://eslint.style/rules/js/lines-around-comment

@alan-agius4 alan-agius4 requested a review from dgp1130 September 10, 2024 08:39
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 10, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review September 10, 2024 08:39
@alan-agius4 alan-agius4 force-pushed the lines-around-comment-lint-rule branch from 734dd7c to a370291 Compare September 10, 2024 08:40
@alan-agius4 alan-agius4 removed the request for review from dgp1130 September 10, 2024 08:58
@alan-agius4 alan-agius4 marked this pull request as draft September 10, 2024 08:59
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It's a minor thing but it definitely helps with readability for me.

@alan-agius4 alan-agius4 removed action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked on upstream labels Sep 10, 2024
@alan-agius4 alan-agius4 force-pushed the lines-around-comment-lint-rule branch from a370291 to 4bf96ce Compare September 10, 2024 16:55
@alan-agius4 alan-agius4 force-pushed the lines-around-comment-lint-rule branch from 4bf96ce to 26c6d2d Compare September 10, 2024 16:56
@alan-agius4 alan-agius4 reopened this Sep 10, 2024
@alan-agius4 alan-agius4 reopened this Sep 11, 2024
@alan-agius4 alan-agius4 force-pushed the lines-around-comment-lint-rule branch from 1ce9f97 to a9d095b Compare September 11, 2024 07:25
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 11, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review September 11, 2024 07:25
@alan-agius4 alan-agius4 force-pushed the lines-around-comment-lint-rule branch from a9d095b to 8686b67 Compare September 11, 2024 07:27
I often struggle with spacing around block comments, so I've decided to add the `lines-around-comment` lint rule to help manage this.

For more details, see the https://eslint.style/rules/js/lines-around-comment
@alan-agius4 alan-agius4 force-pushed the lines-around-comment-lint-rule branch from 8686b67 to 753bf69 Compare September 11, 2024 10:07
@alan-agius4 alan-agius4 merged commit 743188b into angular:main Sep 11, 2024
30 checks passed
@alan-agius4 alan-agius4 deleted the lines-around-comment-lint-rule branch September 11, 2024 10:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants