refactor(ssr): use ReadonlyMap instead of Readonly mapped type
#28404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d type The `Readonly` mapped type only introduces the `readonly` modifier for each property, but `Map` has mutating methods like `clear`, `delete` and `set` that would still remain usable. This commit switches those usages over to the `ReadonlyMap` type which doesn't have any of the mutating methods.
alan-agius4
approved these changes
Sep 12, 2024
alan-agius4
added
target: major
JoostK
force-pushed
the
readonly-map
branch
from
2c627f2 to
d80bd35
Compare
Yep, done, I was waiting to see if all other tests were green 😄 |
alan-agius4
added
action: merge
alan-agius4
approved these changes
Sep 12, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Readonlymapped type only introduces thereadonlymodifier for each property, butMaphas mutating methods likeclear,deleteandsetthat would still remain usable. This commit switches those usages over to theReadonlyMaptype which doesn't have any of the mutating methods.