Skip to content

Conversation

alan-agius4
Copy link
Collaborator

This reverts commit ecc107d83bfdfd9d5dd1087e264892d60361625c.

Passing a custom process.env to Piscina causes Bazel to fail, leading to path leaks and sandbox escapes.

As a result, adev builds encounter errors such as:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@angular/compiler-cli' imported from /home/runner/work/angular/angular/node_modules/@angular/build/src/utils/load-esm.js

Further investigation is needed to determine if this is a bug in Piscina or another underlying issue. For now, the change has been reverted to allow the FW repo to update to the latest version of the CLI packages.

@alan-agius4 alan-agius4 requested a review from clydin September 13, 2024 08:07
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 13, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 13, 2024
@alan-agius4 alan-agius4 merged commit de17cbc into angular:main Sep 13, 2024
34 checks passed
@alan-agius4 alan-agius4 deleted the revert-code-cache branch September 13, 2024 09:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants