Skip to content

Conversation

crisbeto
Copy link
Member

Resolves some type errors that showed up internally.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 17, 2024
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2024
@alan-agius4
Copy link
Collaborator

Looks like the API Extractor doesn't like the new Symbol

Analysis will use the bundled TypeScript version 5.4.2
Internal Error: Unable to follow symbol for "MapIterator"

@JeanMeche
Copy link
Member

JeanMeche commented Sep 17, 2024

Fwiw we dropped support for 5.4 in v19 angular/angular#57577
Edit: It looks like MapIterator is only available in 5.6.

@crisbeto
Copy link
Member Author

Yeah I'll look for a different solution since the latest version of the API extractor is still on 5.4.

Resolves some type errors that showed up internally.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 17, 2024
@crisbeto crisbeto marked this pull request as ready for review September 17, 2024 15:55
@crisbeto
Copy link
Member Author

I've worked around it using a resolution until the API extractor gets updated to TS 5.6.

@crisbeto crisbeto requested a review from clydin September 17, 2024 16:40
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2024
@jkrems jkrems merged commit a3bbe0e into angular:main Sep 18, 2024
33 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular-devkit/core target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants