Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 23, 2024

Instead of attempting to delete all files within the directory, the created symlink can instead be removed on its own. This should prevent odd Windows failures in CI.

Instead of attempting to delete all files within the directory, the created
symlink can instead be removed on its own. This should prevent odd Windows
failures in CI.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Sep 23, 2024
@clydin clydin marked this pull request as ready for review September 23, 2024 17:28
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 23, 2024
@clydin clydin merged commit f05b053 into angular:main Sep 23, 2024
33 checks passed
@clydin
Copy link
Member Author

clydin commented Sep 23, 2024

The changes were merged into the following branches: main, 18.2.x

@clydin clydin deleted the e2e/remove-symlink-ng-add-test branch September 23, 2024 17:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants